Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix analytics user identification #1654

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Oct 10, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at c7476e1

This pull request refactors the user identification and tracking functionality in the frontend. It moves the identify function from the Layout component to the App component and removes unnecessary code from layout.vue.

🤖 Generated by Copilot at c7476e1

App is watching you, tracking your every move
No escape from the identify function
Layout is free from the redundant code
But it can't hide from the eye of App

Why

How

🤖 Generated by Copilot at c7476e1

  • Move the identify function call from the Layout component to the App component to avoid unnecessary or duplicate calls to the analytics service (link, link, link, link)
  • Add the currentUser getter to the App component to access the current authenticated user from the auth module of the Vuex store (link)
  • Add a watcher to the currentUser computed property to call the identify function with the latest user information whenever the user changes (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Oct 10, 2023
@joanagmaia joanagmaia self-assigned this Oct 10, 2023
@joanagmaia joanagmaia merged commit 4fe2ba0 into main Oct 10, 2023
7 checks passed
@joanagmaia joanagmaia deleted the bugfix/analytics-identification branch October 10, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant