Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the existing transaction to merge organizations on enrichment #1661

Merged
merged 3 commits into from
Oct 11, 2023

Conversation

yeganathan18
Copy link
Member

@yeganathan18 yeganathan18 commented Oct 11, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at d911abf

Refactored organizationEnrichmentService and orgService to use database transactions for data consistency and error handling. Updated backend/src/services/premium/enrichment/organizationEnrichmentService.ts to pass the transaction option to orgService.

🤖 Generated by Copilot at d911abf

orgService changed
To use same transaction
Data stays intact

Why

How

🤖 Generated by Copilot at d911abf

  • Pass transaction option to orgService constructor to use same database transaction as organizationEnrichmentService methods (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@yeganathan18 yeganathan18 added the Bug Created by Linear-GitHub Sync label Oct 11, 2023
@yeganathan18 yeganathan18 changed the title Fix auto merge orgs during enrichment Pass the existing transaction to merge organizations on enrichment Oct 11, 2023
@yeganathan18 yeganathan18 merged commit 42c6a84 into main Oct 11, 2023
7 checks passed
@yeganathan18 yeganathan18 deleted the debug/org-enrich-merge branch October 11, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants