Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle org website being null when merging them through enrichment #1662

Merged
merged 6 commits into from
Oct 11, 2023

Conversation

yeganathan18
Copy link
Member

@yeganathan18 yeganathan18 commented Oct 11, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 5df0293

Refactored organizationEnrichmentService.ts to skip domain lookup and service creation for organizations without websites. This reduces the load on the database and the memory usage.

🤖 Generated by Copilot at 5df0293

No findByDomain
If org.website is false
Winter of queries

Why

How

🤖 Generated by Copilot at 5df0293

  • Optimize organization enrichment service by skipping unnecessary calls and checks (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@yeganathan18 yeganathan18 added the Bug Created by Linear-GitHub Sync label Oct 11, 2023
@yeganathan18 yeganathan18 merged commit 6fca272 into main Oct 11, 2023
8 checks passed
@yeganathan18 yeganathan18 deleted the debug/org-enrich-merge branch October 11, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant