Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organizations merge on conflict during enrichment hotfix #1664

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

yeganathan18
Copy link
Member

@yeganathan18 yeganathan18 commented Oct 11, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 110d257

Improved organization enrichment service by removing duplicate organizations and fixing variable declaration. Modified backend/src/services/premium/enrichment/organizationEnrichmentService.ts.

🤖 Generated by Copilot at 110d257

unmergedOrgs now
let, no duplicates by site
enrichment in spring

Why

How

🤖 Generated by Copilot at 110d257

  • Remove duplicate organizations based on website in organization enrichment service (link, link)
  • Change unmergedOrgs from const to let to allow reassignment (link)
  • Add code to iterate over unmergedOrgs and collect and filter out duplicates (link)
  • Log the removed duplicate organizations for debugging purposes (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@yeganathan18 yeganathan18 merged commit 72f9bbb into main Oct 11, 2023
8 checks passed
@yeganathan18 yeganathan18 deleted the org-merge-enrichment-hotfixes branch October 11, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant