Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activities filtering (member page) #1682

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

peoray
Copy link
Contributor

@peoray peoray commented Oct 15, 2023

Changes proposed ✍️

What

Fixes #1595

🤖 Generated by Copilot at e8a0d15

Added a clear filter feature and a no activities message to the activity timeline component. This improves the user experience and functionality of the activity-timeline.vue file in the frontend module.

🤖 Generated by Copilot at e8a0d15

platformFilter clears
activities reload anew
autumn leaves no trace

Why

How

🤖 Generated by Copilot at e8a0d15

  • Add a clearable filter for platforms in the activity timeline (link)
  • Show a message when there are no activities for the selected platform or member (link)
  • Define a method to reload the activities without any platform filter (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 😄 Just added a comment for some small copy fixes

Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@joanagmaia joanagmaia merged commit a86b124 into CrowdDotDev:main Oct 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On a Members page, filtering Activity by Platform removes the data
2 participants