Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix joined on custom platform #1689

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Oct 16, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at b34bfc8

Simplify and fix platform display logic for dashboard members. The file dashboard-members.vue is updated to handle null values and remove an extra condition for showing the last activity platform of dashboard members.

🤖 Generated by Copilot at b34bfc8

getPlatformDetails
Simpler and more robust now
Autumn bugs swept away

Why

How

🤖 Generated by Copilot at b34bfc8

  • Simplify and fix the logic for displaying the member's last activity platform in the dashboard (link, link)
  • Remove the unnecessary condition that checks if the platform is valid in frontend/src/modules/dashboard/components/dashboard-members.vue (link)
  • Add optional chaining and nullish coalescing operators to the platform name expression in the same file (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Bug Created by Linear-GitHub Sync label Oct 16, 2023
@gaspergrom gaspergrom self-assigned this Oct 16, 2023
@gaspergrom gaspergrom merged commit 388d711 into main Oct 17, 2023
6 checks passed
@gaspergrom gaspergrom deleted the bugfix/joined-on-custom-platform branch October 17, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants