Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reddit comment streams #1698

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 16, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at f1a679a

Fixed a bug in the Reddit integration that caused some comments to be missed or cause errors. Added t3_ prefix to link_id in getMoreComments.ts and handled null or undefined comments in processStream.ts.

🤖 Generated by Copilot at f1a679a

t3_ for posts
comments may be missing
autumn leaves fall

Why

How

🤖 Generated by Copilot at f1a679a

  • Prefix link_id parameter with t3_ to fetch more comments for posts from Reddit API (link)
  • Handle empty or malformed responses from Reddit API by making comments variable optional and checking for null or undefined values (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit b0f5c64 into main Oct 16, 2023
8 checks passed
@garrrikkotua garrrikkotua deleted the fix/more-comments-stream-reddit branch October 16, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant