Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix organizations update #1699

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix organizations update #1699

merged 1 commit into from
Oct 16, 2023

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Oct 16, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 7845670

This pull request improves the organization form component and its subcomponents, which allow the user to create or edit an organization profile. It fixes a bug in the identity submission logic and adds the ability to edit the name of the identity in the organization-form-identities.vue component.

🤖 Generated by Copilot at 7845670

formModel changes
identity name editable
autumn of refactor

Why

How

🤖 Generated by Copilot at 7845670

  • Add and refactor formModel computed property to handle identity data in organization-form-identities.vue (link, link, link)
  • Copy all record properties to formModel using spread operator in organization-form-page.vue (link)
  • Fix and improve identity submission logic in submitForm method in organization-form-page.vue (link)
  • Remove unused or irrelevant formModel properties in organization-form-page.vue (link)
  • Add empty line to separate formModel and submitForm sections in organization-form-page.vue (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Oct 16, 2023
@joanagmaia joanagmaia self-assigned this Oct 16, 2023
@joanagmaia joanagmaia merged commit 372d2f2 into main Oct 16, 2023
6 checks passed
@joanagmaia joanagmaia deleted the bugfix/organizations-update branch October 16, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants