Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lib install script #1717

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix lib install script #1717

merged 1 commit into from
Oct 17, 2023

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 17, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at a926f30

Improved the portability and security of the install_lib_packages.sh script by using $0 as the xargs argument and passing it as a parameter.

🤖 Generated by Copilot at a926f30

xargs argument
now more portable and safe
autumn of {} ends

Why

How

🤖 Generated by Copilot at a926f30

  • Replace {} with $0 and pass it as a parameter to bash command in install_lib_packages.sh to avoid issues with spaces or special characters (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screehshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit e8ac18a into main Oct 17, 2023
6 checks passed
@garrrikkotua garrrikkotua deleted the fix/lib-install-script branch October 17, 2023 15:19
@garrrikkotua garrrikkotua restored the fix/lib-install-script branch October 17, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant