Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tracing #1725

Merged
merged 3 commits into from
Oct 18, 2023
Merged

More tracing #1725

merged 3 commits into from
Oct 18, 2023

Conversation

sausage-todd
Copy link
Contributor

@sausage-todd sausage-todd commented Oct 18, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at f9b4ca1

This pull request adds and updates OpenTelemetry instrumentation for Redis and PostgreSQL in the services/libs/tracing and services/libs/database modules. These changes enable tracing of database operations and improve the observability and performance monitoring of the service. The pull request also increases the maximum number of connections in the database pool.

🤖 Generated by Copilot at f9b4ca1

We're sailing on the digital sea, with databases and traces
We're instrumenting Redis and PG, to monitor our paces
Heave ho, heave ho, on the count of three
We're updating dbConnection.max to boost our concurrency

Why

How

🤖 Generated by Copilot at f9b4ca1

  • Increase the maximum number of connections in the database pool from 5 to 20 to improve performance and concurrency (link)
  • Replace the @opentelemetry/instrumentation-redis dependency with @opentelemetry/instrumentation-redis-4 and add the @opentelemetry/instrumentation-pg dependency to update the tracing packages for Redis and PostgreSQL (link, link, link)
  • Remove the @opentelemetry/instrumentation-redis package from the package-lock.json file to reflect the dependency change (link)
  • Add the @opentelemetry/instrumentation-pg package and its dependencies to the package-lock.json file to reflect the dependency addition (link, link, link, link, link)
  • Add the PgInstrumentation instance to the array of instrumentations in the getServiceTracer function in tracer.ts to enable the tracing of PostgreSQL queries (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@sausage-todd sausage-todd merged commit 7b165c0 into main Oct 18, 2023
8 checks passed
@sausage-todd sausage-todd deleted the more-tracing branch October 18, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant