Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discord error handling #1726

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Fix discord error handling #1726

merged 2 commits into from
Oct 19, 2023

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 18, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at fe418f7

This pull request improves the error handling logic for the Discord integration module. It extracts a common function to handle and log Discord errors and applies it to the getMembers and getMessages functions. It also simplifies the function signatures and the try-catch structures in these files.

🤖 Generated by Copilot at fe418f7

getMembers, getMessages
Refactored with common handler
Simpler code, like spring

Why

How

🤖 Generated by Copilot at fe418f7

  • Refactor error handling logic for Discord API calls using a common function (link, link, link, link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit 43286f9 into main Oct 19, 2023
8 checks passed
@garrrikkotua garrrikkotua deleted the fix/discord-error-handling branch October 19, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant