Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sleeping time in rate limiter #1732

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 19, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at a05e764

Fixed a bug in the RateLimiter class that caused incorrect rate limit errors. Changed the sleepTime calculation to use the timeWindowSeconds property instead of the maxRequests property in services/libs/redis/src/rateLimiter.ts.

🤖 Generated by Copilot at a05e764

sleepTime adjusts
using timeWindowSeconds
bug fix for winter

Why

How

🤖 Generated by Copilot at a05e764

  • Fix rate limit sleep time calculation to use time window instead of max requests (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit ed08acb into main Oct 19, 2023
5 of 6 checks passed
@garrrikkotua garrrikkotua deleted the hotfix/time-in-rate-limiter branch October 19, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant