Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix per page in Discord integration #1733

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 19, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 7843ea1

Refactored the Discord integration service to use streams and pagination for better performance and memory efficiency. Adjusted the perPage parameters of getMembers and getChannels in services/libs/integrations/src/integrations/discord/processStream.ts.

🤖 Generated by Copilot at 7843ea1

To improve the Discord service's speed
The perPage params were tweaked
Instead of one big fetch
They used streams and pag'ed
The data processing technique

Why

How

🤖 Generated by Copilot at 7843ea1

  • Refactored the Discord integration service to use streams and pagination instead of loading all the data at once (link, link)
  • Increased the perPage parameter of the getMembers function from 500 to 1000 to improve performance and efficiency (link)
  • Decreased the perPage parameter of the getChannels function from 500 to 100 to reduce data and memory usage (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit e2ed88e into main Oct 19, 2023
6 checks passed
@garrrikkotua garrrikkotua deleted the hotfix/discord-per-page branch October 19, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant