Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rate limiters in Discord #1739

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 20, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 8c12c70

Refactored the Discord integration module by removing the rate limiting logic from the individual API functions and moving it to a middleware layer. This improved the code readability, maintainability, and performance of the services/libs/integrations/src/integrations/discord/api files.

🤖 Generated by Copilot at 8c12c70

We are the masters of the Discord API
We don't need no rate limiter to set us free
We simplify the code and unleash the power
We crush the rate limits with our refactoring hour

Why

How

🤖 Generated by Copilot at 8c12c70

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit 6affe7e into main Oct 20, 2023
6 checks passed
@garrrikkotua garrrikkotua deleted the improve/remove-rate-limiter branch October 20, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant