Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord fix when channels are not avaliable #1767

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 25, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 90302f2

Improved error handling and logging for Discord integration. Added fallback and early return cases to getChannels and processRootStream functions in services/libs/integrations/src/integrations/discord files.

🤖 Generated by Copilot at 90302f2

getChannels fails
empty array as fallback
autumn leaves no trace

Why

How

🤖 Generated by Copilot at 90302f2

  • Add fallback case and check for empty channels in Discord integration (link, link)
  • In getChannels.ts, return an empty array if the guild has no channels or the API request fails (link)
  • In processStream.ts, log a warning and return early if the stream contains no channels for a given guild (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit 37faa64 into main Oct 25, 2023
8 checks passed
@garrrikkotua garrrikkotua deleted the fix/discord-small-fixes branch October 25, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant