Migrate Discourse integration to the new framework #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work. Quick question: When will the docs be updated so anyone can add new integrations? |
garrrikkotua
added
Improvement
epipav
reviewed
Nov 1, 2023
| } from '../types' | ||
| import { IProcessStreamContext } from '../../../types' | ||
|
|
||
| const serializeArrayToQueryString = (params: object) => |
There was a problem hiding this comment.
nit: we can call this serializeObjecttoQueryString instead, what do u think?
Comment on lines
+11
to
+14
| ctx.log.info({ | ||
| message: 'Fetching categories from Discourse', | ||
| forumHostName: params.forumHostname, | ||
| }) |
There was a problem hiding this comment.
we can update this logging, it's same as getCategories
| // wait 5 mins | ||
| throw new RateLimitError(5 * 60, 'discourse/gettopics') | ||
| } | ||
| ctx.log.error({ err, params }, 'Error while getting Discourse categories') |
Comment on lines
+10
to
+11
| // this methods returns ids of posts in a topic | ||
| // then we need to parse each topic individually (can be batched) |
There was a problem hiding this comment.
let's either delete or update the comment, it's from getPostsFromTopic
| ) | ||
| }) | ||
|
|
||
| // we aslo need to trigger nextPageStream |
services/libs/integrations/src/integrations/discourse/processStream.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed ✍️
What
🤖 Generated by Copilot at 35081c1
Refactored the discourse integration logic to use the new service SQS queue and the integrations library. Removed the old node worker SQS queue and the
DiscourseIntegrationServiceclass. Added new functions and files to handle the discourse API calls, stream generation, data processing, and webhook processing. Commented out the discourse webhook endpoint temporarily.
🤖 Generated by Copilot at 35081c1
Why
How
🤖 Generated by Copilot at 35081c1
Checklist ✅
Feature,Improvement, orBug.