Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tasks button and fix tasks routes #1794

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Oct 31, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 0ff3e34

This pull request updates the frontend to show suggested tasks even when there are no open tasks, and to use a consistent plural form for the task routes. It modifies dashboard-task.vue and task-routes.js accordingly.

🤖 Generated by Copilot at 0ff3e34

v-if condition gone
UI more consistent
suggested tasks show

Why

How

🤖 Generated by Copilot at 0ff3e34

  • Change the route for the TaskPage component to use the plural form /tasks and add a redirect from the old route /task (link)
  • Remove the v-if condition from the div element that contains the open tasks and the suggested tasks in the DashboardTask component to show them regardless of the open tasks count (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Oct 31, 2023
@joanagmaia joanagmaia self-assigned this Oct 31, 2023
@joanagmaia joanagmaia merged commit ee165bc into main Oct 31, 2023
6 checks passed
@joanagmaia joanagmaia deleted the bugfix/tasks-button branch October 31, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant