Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize GitHub integration #1796

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Oct 31, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 7ce814b

Improve GitHub integration by using cache and organization data. Refactor processStream.ts to use a global cache with a prefix and a new function to fetch and store the organization data from GitHub.

🤖 Generated by Copilot at 7ce814b

We are the masters of the cache
We use the prefix to avoid the clash
We get the data from the org
We integrate with GitHub like a forge

Why

How

🤖 Generated by Copilot at 7ce814b

  • Add a new function getOrganizationData to fetch the organization data from the GitHub API or the global cache with a prefix (link)
  • Refactor the getMemberEmail function to use the global cache and the prefix for the cache keys (link, link)
  • Simplify the prepareMember function by using the getOrganizationData function instead of repeating the logic (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit baeacd3 into main Nov 1, 2023
25 checks passed
@garrrikkotua garrrikkotua deleted the improve/optimize-github-integration branch November 1, 2023 09:23
sausage-todd pushed a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant