Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort merge suggestions by confidence #1826

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

joanreyero
Copy link
Contributor

@joanreyero joanreyero commented Nov 7, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 0503354

Improved the member merge feature by sorting the candidates by similarity score. Modified the getMembersToMerge method in memberRepository.ts to implement the new ordering logic.

🤖 Generated by Copilot at 0503354

getMembersToMerge
Sorts by similarity score
Autumn leaves falling

Why

How

🤖 Generated by Copilot at 0503354

  • Order the results of getMembersToMerge by similarity score instead of joined date (link). This improves the user experience by showing the most similar members first in the merge interface. The similarity score is calculated using a combination of factors such as name, email, location, and skills in the backend/src/database/repositories/memberRepository.ts file.

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanreyero joanreyero added the Improvement Created by Linear-GitHub Sync label Nov 7, 2023
@joanreyero joanreyero changed the title Changed Sort merge suggestions by confidence Nov 7, 2023
@joanreyero joanreyero merged commit 376c625 into main Nov 7, 2023
8 checks passed
@joanreyero joanreyero deleted the improvement/merge-suggestions-sorted-similarity branch November 7, 2023 14:10
sausage-todd pushed a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant