Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix manual merge profile flow #1830

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Nov 8, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 39a4314

Added member-merge-dialog.vue component to allow merging members in the frontend. Improved navigation and promise handling in both member-merge-dialog.vue and organization-merge-dialog.vue components.

🤖 Generated by Copilot at 39a4314

We are the code of the merge, we copy and adapt
We use the router to replace, we find the path of the pact
We destructure the id, we handle the promise with then
We are the code of the merge, we are the masters of the zen

Why

How

🤖 Generated by Copilot at 39a4314

  • Import and use useRouter function to access router instance in script setup (link, link)
  • Replace router.push with router.replace to update current route with merged entity id in doFind function (link, link)
  • Adapt code from organization-merge-dialog.vue to member-merge-dialog.vue component, destructure id property from props or value objects (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Nov 8, 2023
@joanagmaia joanagmaia self-assigned this Nov 8, 2023
@joanagmaia joanagmaia merged commit 5e3bec5 into main Nov 9, 2023
6 checks passed
@joanagmaia joanagmaia deleted the bugfix/manual-merge-profile-flow branch November 9, 2023 10:14
sausage-todd pushed a commit that referenced this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants