Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter to X #1835

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Twitter to X #1835

merged 3 commits into from
Nov 14, 2023

Conversation

gaspergrom
Copy link
Contributor

@gaspergrom gaspergrom commented Nov 10, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 94a6536

Renamed the native Twitter integration to X/Twitter and updated the UI and configuration to use the new name, logo, and description. This change prepares for the deprecation of the native integration and the transition to the Zapier-based one.

🤖 Generated by Copilot at 94a6536

Sing, O Muse, of the mighty deeds of the Zapier team,
Who changed the face of the integration with the bird of tweets,
And gave it a new name, X/Twitter, and a splendid logo bright,
And a description fit to charm the users of the web.

Why

How

🤖 Generated by Copilot at 94a6536

  • Renamed the integration from Twitter to X/Twitter and updated the logo and description in the configuration file (link)
  • Changed the text in the modal header and body to use the new name and explain the alternative solution using Zapier (link, link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@gaspergrom gaspergrom added the Improvement Created by Linear-GitHub Sync label Nov 10, 2023
@gaspergrom gaspergrom self-assigned this Nov 10, 2023
Copy link
Contributor

@joanagmaia joanagmaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to:

  • update title in twitter-connect-drawer.vue
  • settings-pricing-plans.js
  • modules/organization/config/filters/activeOn/options.ts
  • organization-form-identities.vue
  • member-reach
  • new-member-filter-options
  • new-activity-filter-options
  • crowd-icons.svg -> need to update twitter's svg there

@gaspergrom gaspergrom merged commit 21bcd53 into main Nov 14, 2023
5 checks passed
@gaspergrom gaspergrom deleted the improvement/twitter-to-x branch November 14, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants