Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FormbricksJs dependency #1840

Merged

Conversation

mattinannt
Copy link
Contributor

@mattinannt mattinannt commented Nov 13, 2023

Changes proposed ✍️

We just updated our @formbricks/js package with a new workflow and are currently experiencing problems with old versions of @formbricks/js with our current cloud backend.
I updated @formbricks/js in the crowd.dev codebase to the newest version and also slightly changed the workflow since the setUserId is now deprecated.

What

🤖 Generated by Copilot at f3eb962

This pull request updates the @formbricks/js dependency to the latest version and refactors the code to use a new function setupFormbricks that initializes the Formbricks library with the current user data. This improves the code quality and enables the use of new features and bug fixes from the Formbricks library.

🤖 Generated by Copilot at f3eb962

Sing, O Muse, of the skillful coder who updated the package.json file
And brought the latest version of @formbricks/js to his project's pile
He also crafted a new function, setupFormbricks, with cunning art
To initialize the library with the user's data and survey part

Why

How

🤖 Generated by Copilot at f3eb962

  • Update the version of the @formbricks/js dependency from 1.0.2 to 1.2.0 in the package.json and package-lock.json files to use the latest features and bug fixes of the Formbricks library (link, link, link, link)
  • Define and export a new function setupFormbricks in the formbricks.js module that initializes the Formbricks library with the current user data (link)
  • Replace the multiple Formbricks method calls with a single call to the setupFormbricks function in the mutations.js file to simplify the code and avoid repetition (link, link, link)
  • Remove the trailing commas and replace the single quotes with double quotes in the config.js file to follow the code style and formatting rules of the project (link, link, link)
  • Simplify the composedConfig object definition in the config.js file by using the tenantMode and isPlanEnabled variables directly instead of repeating their values (link)
  • Remove the trailing comma in the selectAndSaveOnStorageFor function call in the mutations.js file to follow the code style and formatting rules of the project (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2023

CLA assistant check
All committers have signed the CLA.

@mattinannt mattinannt force-pushed the feature/update-formbricks-1.2.0 branch from f3eb962 to e6619e8 Compare November 13, 2023 14:11
@gaspergrom gaspergrom merged commit 70fa5be into CrowdDotDev:main Nov 14, 2023
5 checks passed
sausage-todd pushed a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants