Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSS graph display #1841

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix OSS graph display #1841

merged 1 commit into from
Nov 14, 2023

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Nov 13, 2023

Changes proposed ✍️

What

🤖 Generated by Copilot at 34ab45e

Improved the UI and code quality of the member contributions view component. Fixed some bugs related to topics and tooltips.

🤖 Generated by Copilot at 34ab45e

Sing, O Muse, of the skillful coder who refined
The member-view-contributions.vue with artful mind,
Who stripped away the needless borders that marred the sight
And made the tooltip sections vanish when there was no light.

Why

How

🤖 Generated by Copilot at 34ab45e

  • Remove and replace border styles in tooltip sections for repository name and contributions to avoid overlapping and improve consistency (link, link)
  • Add conditional rendering to tooltip section for topics to only display it if the target node has any topics (link, link)
  • Handle undefined values for topics when merging existing node and new contribution by using optional chaining and nullish coalescing operators (link)
  • Check if contribution has any topics before looping over them and adding them to the topicMap object to avoid calling forEach on undefined (link)
  • Change style tag attribute from css to scss to enable Sass features in member-view-contributions.vue (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Nov 13, 2023
@joanagmaia joanagmaia self-assigned this Nov 13, 2023
@joanagmaia joanagmaia merged commit 92818ee into main Nov 14, 2023
6 checks passed
@joanagmaia joanagmaia deleted the bugfix/missing-oss-graph branch November 14, 2023 09:50
sausage-todd pushed a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants