Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data-sink-worker when activity marked deleted #1846

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

garrrikkotua
Copy link
Contributor

@garrrikkotua garrrikkotua commented Nov 15, 2023

…marked deleted

Changes proposed ✍️

What

🤖 Generated by Copilot at 5b3e86e

This pull request adds support for soft-deleting activities and handling member syncs in the ActivityService of the data_sink_worker app. It updates the IDbActivity interface, the ActivityRepo class, and the processActivity method to use the new deletedAt property.

🤖 Generated by Copilot at 5b3e86e

Oh we are the ActivityService crew
We process the data old and new
We mark the deleted ones with deletedAt
And sync the members in a snap

Why

How

🤖 Generated by Copilot at 5b3e86e

  • Add deletedAt property to IDbActivity interface to mark deleted activities (link)
  • Modify findExisting method in ActivityRepo to include deletedAt column in query result (link)
  • Skip processing activities that have deletedAt value in processActivity method in ActivityService (link)
  • Trigger member sync only for activities that have memberId value in processActivity method in ActivityService (link)

Checklist ✅

  • Label appropriately with Feature, Improvement, or Bug.
  • Add screenshots to the PR description for relevant FE changes
  • New backend functionality has been unit-tested.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.

@garrrikkotua garrrikkotua merged commit 1ea935e into main Nov 15, 2023
7 of 8 checks passed
@garrrikkotua garrrikkotua deleted the fix/dont-created-activity-when-its-deleted branch November 15, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant