Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization new filters #239

Merged
merged 1 commit into from Nov 21, 2022

Conversation

joanagmaia
Copy link
Contributor

Changes proposed ✍️

  • Create # employees and # members filter fields
  • Add both fields to Organization model with filterable option set to true
  • Add defaultOperator prop to Filter type number so that it does not show the operator selector if the defaultOperator is set to between.
  • Refactor between logic in build-api-payload:
    • Prevent empty values to be sent as null
    • When both bottom and top limit are set, use the between operator
    • When only bottom limit is set, use the gte operator
    • When only top limit is set, use the lte operator

Screenshots (front-end changes only)

Screenshot 2022-11-21 at 12 56 24

Screenshot 2022-11-21 at 12 56 31

Checklist ✅

  • Label appropriately with type:feature 🚀, type:enhancement ✨, type:bug 🐞, or type:documentation 📜.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated
    • Front-end: frontend/.env.dist
    • Backend: backend/.env.dist, backend/.env.dist.staging, backend/.env.dist.staging.
    • Configuration docs have been updated.
    • Team members only: update environment variables in Password manager and update the team
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@netlify
Copy link

netlify bot commented Nov 21, 2022

Deploy Preview for open-crowd-prod failed.

Name Link
🔨 Latest commit 746e18e
🔍 Latest deploy log https://app.netlify.com/sites/open-crowd-prod/deploys/637b6b27beda4e0009f26207

@netlify
Copy link

netlify bot commented Nov 21, 2022

Deploy Preview for open-devfounders failed.

Name Link
🔨 Latest commit 746e18e
🔍 Latest deploy log https://app.netlify.com/sites/open-devfounders/deploys/637b6b27e805a800085d584d

Copy link
Contributor

@mariobalca mariobalca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👏
Thanks for refactoring the between operator, in the build-api-payload.js
Feel free to merge 💪

@joanagmaia joanagmaia merged commit 448c8dc into main Nov 21, 2022
@joanagmaia joanagmaia deleted the feature/organization-new-filter-components branch November 21, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants