Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix range filters #290

Merged
merged 3 commits into from Nov 30, 2022
Merged

Fix range filters #290

merged 3 commits into from Nov 30, 2022

Conversation

joanagmaia
Copy link
Contributor

@joanagmaia joanagmaia commented Nov 30, 2022 •
edited

Changes proposed ✍️

  • For between operators, disable apply button if both values are not valid
  • Fix filter-type-date for when between is selected

Relates to #284

Screenshots (front-end changes only)

Screenshot 2022-11-30 at 14 36 59
Screenshot 2022-11-30 at 14 37 02

Screenshot 2022-11-30 at 15 45 34
Screenshot 2022-11-30 at 15 45 39

Checklist ✅

  • Label appropriately with Feature, Enhancement, or Bug.
  • Tests are passing.
  • New backend functionality has been unit-tested.
  • Environment variables have been updated:
    • Local frontend configuration: frontend/.env.dist.local, frontend/.env.dist.composed.
    • Local backend: backend/.env.dist.local, backend/.env.dist.composed.
    • Configuration docs have been updated.
    • Team members only: update environment variables in override, staging and production env. files and trigger update config script.
  • API documentation has been updated (if necessary) (see docs on API documentation).
  • Quality standards are met.
  • All changes have been tested in a staging site.
  • All changes are working locally running crowd.dev's Docker local environment.

@joanagmaia joanagmaia added the Bug Created by Linear-GitHub Sync label Nov 30, 2022
@joanagmaia joanagmaia self-assigned this Nov 30, 2022
joanreyero
joanreyero approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@joanreyero joanreyero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@joanagmaia joanagmaia merged commit cce42e2 into main Nov 30, 2022
@joanagmaia joanagmaia deleted the bug/range-filters branch November 30, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joanreyero joanreyero joanreyero approved these changes

Assignees

@joanagmaia joanagmaia

Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joanagmaia @joanreyero