Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ BUG ] JSONDecode error on RTR_DeleteSession #238

Closed
jshcodes opened this issue Aug 3, 2021 · 0 comments · Fixed by #244
Closed

[ BUG ] JSONDecode error on RTR_DeleteSession #238

jshcodes opened this issue Aug 3, 2021 · 0 comments · Fixed by #244
Assignees
@jshcodes
Labels
bug 🐛 Something isn't working RTR Real Time Response issues and questions

Comments

@jshcodes
Copy link
Member

jshcodes commented Aug 3, 2021 •
edited

Describe the bug
The RTR_DeleteSession operation returns no content on success, but headers and a 204 status code are returned. Update the perform_request method within _util.py to handle this scenario.

To Reproduce
Create a RTR session, then try and delete the session using Real_Time_Response.RTR_DeleteSession.

Expected behavior
A 204 status code is returned with an empty response. No error is generated.

Environment (please complete the following information):

  • OS: Mac OS 10.15
  • Python: 3.9
  • FalconPy: 0.5.5
@jshcodes jshcodes added bug 🐛 Something isn't working RTR Real Time Response issues and questions labels Aug 3, 2021
@jshcodes jshcodes self-assigned this Aug 3, 2021
jshcodes added a commit that referenced this issue Aug 4, 2021
@jshcodes
Fixed JSONDecode error on no content. Closes #238.
0b278d1
@jshcodes jshcodes mentioned this issue Aug 6, 2021
Merged
3 tasks
jshcodes added a commit that referenced this issue Aug 6, 2021
@jshcodes
[DEPLOY] v0.5.6 - Credential authentication, JSONDecode error bug fix…
30388bb 
…es. FalconDebug. (#244)

* Fixed JSONDecode error on no content. Closes #238.

* Updated to expand code coverage for new code paths

* Add debug.py to linting workflow

* Refactor, new functionality and linting.

* Startup utility for the interactive debugger

* debug.py is now reviewed for linting issues.

* Debugger is now available directly from the module

* Fix for debugger imports when loaded in the module

* Adjusted IDP unit test to decode responses

* Data type fix

* RTR session test is a bit flaky on multi-execution

* Data type fix

* Third times the charm

* Skip Session connect when not a 3.9 runner

* Added list_modules method

* Comment cleanup

* Added class types diagram

* Update README.md

* Update README.md

* Fix typo

* Update README.md

* Update README.md

* Bump version -> 0.5.6

* Unit test adjustment to resolve revocation failure

* Fix typo

* Fix typo

* Service class custom attributes fix. Closes #242.

* Unit test adjustment to combat flakiness.

* Added project_urls to package metadata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshcodes jshcodes

Labels
bug 🐛 Something isn't working RTR Real Time Response issues and questions
Projects
None yet
Milestone
No milestone
1 participant
@jshcodes