Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ BUG ] Service Class credential authentication does not respect base_url or proxy settings. #242

Closed
jshcodes opened this issue Aug 5, 2021 · 2 comments · Fixed by #244
Closed

[ BUG ] Service Class credential authentication does not respect base_url or proxy settings. #242

jshcodes opened this issue Aug 5, 2021 · 2 comments · Fixed by #244
Assignees
@jshcodes
Labels
authentication Issues or questions regarding authentication bug 🐛 Something isn't working

Comments

@jshcodes
Copy link
Member

jshcodes commented Aug 5, 2021 •
edited

Describe the bug
The base class of all service classes, _service_class.py does not respect values passed for the BASE_URL, PROXY or SSL_VERIFY attributes when creating an instance of the auth_object for credential authentication.

To Reproduce
Create an instance of any service class, and change it's base_url to US-2 or disable SSL verification with ssl_verify=False.

Expected behavior
The service class is instantiated with an auth_object that respects the passed attribute values.

Environment (please complete the following information):

  • OS: All supported
  • Python: All supported
  • FalconPy: <=0.5.5
@jshcodes jshcodes added bug 🐛 Something isn't working authentication Issues or questions regarding authentication labels Aug 5, 2021
@jshcodes
Copy link
Member Author

jshcodes commented Aug 5, 2021

Fix for this issue is being tested now and will be committed shortly.

@jshcodes jshcodes self-assigned this Aug 6, 2021
jshcodes added a commit that referenced this issue Aug 6, 2021
@jshcodes
Service class custom attributes fix. Closes #242.
3269c2b
@jshcodes jshcodes mentioned this issue Aug 6, 2021
Merged
3 tasks
@mccbryan3
Copy link
Contributor

mccbryan3 commented Aug 6, 2021 •
edited

I have tested the code fix for auth on us-2 and testing has worked out well with this fix

jshcodes added a commit that referenced this issue Aug 6, 2021
@jshcodes
[DEPLOY] v0.5.6 - Credential authentication, JSONDecode error bug fix…
30388bb 
…es. FalconDebug. (#244)

* Fixed JSONDecode error on no content. Closes #238.

* Updated to expand code coverage for new code paths

* Add debug.py to linting workflow

* Refactor, new functionality and linting.

* Startup utility for the interactive debugger

* debug.py is now reviewed for linting issues.

* Debugger is now available directly from the module

* Fix for debugger imports when loaded in the module

* Adjusted IDP unit test to decode responses

* Data type fix

* RTR session test is a bit flaky on multi-execution

* Data type fix

* Third times the charm

* Skip Session connect when not a 3.9 runner

* Added list_modules method

* Comment cleanup

* Added class types diagram

* Update README.md

* Update README.md

* Fix typo

* Update README.md

* Update README.md

* Bump version -> 0.5.6

* Unit test adjustment to resolve revocation failure

* Fix typo

* Fix typo

* Service class custom attributes fix. Closes #242.

* Unit test adjustment to combat flakiness.

* Added project_urls to package metadata
@CrowdStrike CrowdStrike locked and limited conversation to collaborators Oct 19, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees

@jshcodes jshcodes

Labels
authentication Issues or questions regarding authentication bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@mccbryan3 @jshcodes