Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better countdown handling #27

Closed
cnowacek opened this issue Jun 28, 2013 · 2 comments
Closed

Better countdown handling #27

cnowacek opened this issue Jun 28, 2013 · 2 comments

Comments

@cnowacek
Copy link

The countdown is pretty coarse….it will display 1 month to go when there are actually nearly two months…maybe this can be improved?

@liuhenry
Copy link
Contributor

We're currently using the rails view helper to render the time on the server, but it may be a better idea to send over the unix expiration date, and use a javascript library like Moment.js to render the countdown on the client side.

However, we also probably want to modify the time thresholds to something like:
< 1 minute to 2 hours - show minutes (1 - 119 minutes)
2 hours to 3 days - show hours (2 - 72 hours)
3 days to 4 months (3 days - 120 days)
4 months up - show months

We don't want to use weeks, and it's unlikely that a campaign will extend into the 4mo+ timeline.

liuhenry added a commit that referenced this issue Feb 3, 2014
@liuhenry
Copy link
Contributor

liuhenry commented Feb 3, 2014

#201 merged

@liuhenry liuhenry closed this as completed Feb 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants