issue #27 Better Countdown Handling #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <span style="width:100px"><%= distance_of_time_in_words_to_now(@campaign.expiration_date).gsub(/\d/, "").gsub("about", "") %> left</span> | ||
| <script type="text/javascript"> | ||
| $(function() { | ||
| var date_expiration = '<%= @campaign.expiration_date %>'; |
There was a problem hiding this comment.
Maybe we should use the unix timestamp for this, so @campaign.expiration_date.to_i instead
|
@rmostafa - it looks like there are issues around the timezone conversion from UTC to the client's local time, so I suggested some changes above that could help. Could we also try to move the inline JS to campaign.js.coffee? |
| var date_expiration = '<%= @campaign.expiration_date %>'; | ||
| var date_moment = moment(date_expiration, 'YYYY-MM-DD HH:mm:ss'); | ||
| var months = date_moment.diff(moment(), 'months'); | ||
| var refDate = 'Months'; |
There was a problem hiding this comment.
lets also use lowercase 'months' for the date descriptors
|
+1 |
liuhenry
added a commit
that referenced
this pull request
Feb 3, 2014
issue #27 Better Countdown Handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.