Use class naming conventions on summary page #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The naming of classes used in the markup did not quite fit with the [naming convention](https://github.com/alphagov/digitalmarketplace-frontend-toolkit/tree/master/scss#naming). This meant that the summary page in the toolkit was not getting the CSS applied:  Now it is: 
quis
force-pushed
the
summary-page-markup-2
branch
from
d1a546c
to
f0eccf9
Compare
tombye
added a commit
that referenced
this pull request
Feb 19, 2015
Use class naming conventions on summary page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces #25 (same changes, but against
masternotgh-pages).The naming of classes used in the markup did not quite fit with the naming convention.
This meant that the summary page in the toolkit was not getting the CSS applied.