Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use class naming conventions on summary page #25

Closed
wants to merge 1 commit into from

Conversation

quis
Copy link
Contributor

@quis quis commented Feb 9, 2015

The naming of classes used in the markup did not quite fit with the naming convention.

This meant that the summary page in the toolkit was not getting the CSS applied:

image

Now it is:

image

Also brings in the change to the summary page from #24.

The naming of classes used in the markup did not quite fit with the
[naming convention](https://github.com/alphagov/digitalmarketplace-frontend-toolkit/tree/master/scss#naming)

This meant that the summary page in the toolkit was not getting the
CSS applied. Now it is.
@quis
Copy link
Contributor Author

quis commented Feb 10, 2015

This PR is out of date if #26 gets merged. I would favour closing it and making a new request against master.

@quis quis force-pushed the gh-pages branch 2 times, most recently from 2f64ecd to 1f2c677 Compare February 16, 2015 11:35
@quis quis closed this Feb 18, 2015
@quis quis deleted the summary-page-markup branch February 18, 2015 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant