Responsive Site #265
Responsive Site #265
Conversation
… with form elements using labels that affixes to top. Need to reenable drag & drop and fix other pages on small devices.
… Adding new questions doesn't work yet.
… styling (padding issues) on address question form inputs.
|
Drag and drop works. The new blocks on the toolbar move around a bit when being dragged since it removes the dragged block and then puts it back. I haven't really found a good solution to that yet. I think I'm mostly done with the questions page. I'll probably get a chance to look at some of the other pages and the header tomorrow. |
- commits to master will still go to gh-pages - uses value of TRAVIS_PULL_REQUEST to change submodule name when value is not 'false' - value of 'false' indicates in our case a commit to master - uses a parameter for submodule name instead of hard coded gh-pages
ryancarlson
force-pushed
the
responsive
branch
from
60cec20
to
1dd1cad
Compare
ryancarlson
force-pushed
the
responsive
branch
from
a0e0de0
to
f2242cf
Compare
…and cleaned up styling. Made links under event name darker
Conflicts: app/views/eventDetails/regTypes.html
|
I think I'm mostly done going through the pages and making them responsive and fixing CSS stuff. There are a couple of minor things I still see:
Is there anything else that should be fixed on the responsive site? Make sure I didn't miss any pages :) I didn't do much with the front end other than a few spacing issues. |
| @@ -199,6 +197,101 @@ angular.module('confRegistrationWebApp') | |||
| }); | |||
| }; | |||
|
|
|||
| $scope.questions = [ | |||
There was a problem hiding this comment.
Would this model belong better in a different file/folder? The angular-ui-tree drag and drop component wanted to bind to a model for it's drag & drop so this is just looped through in a ng-repeat in https://github.com/CruGlobal/conf-registration-web/blob/responsive/app/views/eventForm.html#L21. I'm not sure if there is good place to put models in the directory structure of AngularJS.
Add profile answers to registrant object
…eConfig controller. Cleaned up some code relating to angular-ui-tree, updated it, and moved questions to questionToolbar directive.
Confirm dialog of page deletion
…th it being clickable
Move Registration Type delete btn to inside of panel
…maller. Change margin so there isn't extra space when stacked and it is vertically centered on both reg-types and question pages.
Fixes from shrinking fa-inset size
…rom payments tab when editing. Fix spacing issue causing horizontal scrolling. Changed <input type="number"> step to 1 for currency values. Made expenses tab editing happen inline.
Payments Modal Improvements
…function parameters.
…l be added later when API changes are complete
Refactor modalMessage to use json objects instead of function parameters
Check for undefined payment method
Cru event fields
So I was thinking about the questions page and how it was not very mobile friendly both because the drag and drop didn't work and because nothing scaled down to the phone size. I was going to prototype it a little bit and see what ideas I had but it turned into much more than that with a new questions toolbar, pages and their blocks in panels and toolbars for each of those blocks.
I completely killed the drag functionality with my HTML and CSS rewrite although if this moves forward I intend to add it back. It was nice to not have to worry about it as I modified stuff and the current implementation didn't work on touch devices anyways.
I was looking at using one of these libraries for drag and drop since they work on touch devices:
http://jimliu.github.io/angular-ui-tree/index.html - Has great Angular bindings. I successfully used it to reorder the toolbar of new questions (although I haven't committed that yet)
http://rubaxa.github.io/Sortable/
http://touchpunch.furf.com/
What are your guys' initial thoughts? I probably should have discussed it first but I got a piece of it working and just kept going. I think it is more user friendly but I would like to hear feedback. Also, since I enabled responsiveness, some of the other pages and the header don't scale correctly in narrower viewports. That would take a bit to go through and fix but it shouldn't be too bad and should be done anyway if we want the site to be responsive.
This is NOT ready to merge, I just wanted to share it.
Also the delete page btn is a little big but I was trying to figure out what to do with it. Maybe I'll split it into a separate button group...