Upgrade webpack-dev-server and fix public path which is now validated… #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrandall22
reviewed
Jun 2, 2017
| @@ -137,7 +137,8 @@ module.exports = env => { | |||
| '/etc': aemDomain, | |||
| '/designations': aemDomain | |||
| }, | |||
| port: 9000 | |||
| port: 9000, | |||
| public: "localhost.cru.org:9000" | |||
There was a problem hiding this comment.
This is the value for localhost, but wouldn't be for other environments. Not sure if that matters.
There was a problem hiding this comment.
This dev server is only for development. S3 serves the js everywhere else. This should be good.
Omicron7
approved these changes
Jun 2, 2017
wrandall22
approved these changes
Jun 2, 2017
adammeyer
approved these changes
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in 2.4.3
Bill ran into this I'm assuming because he used npm and npm ignores the yarn lock file and grabbed the newest version of
webpack-dev-serverfor him.localhost.cru.orgwas giving aInvalid Host headererror.https://github.com/webpack/webpack-dev-server/releases/tag/v2.4.3
webpack/webpack-dev-server#882