Skip to content
This repository has been archived by the owner on Sep 29, 2021. It is now read-only.

Update Dockerfile to use ECR, ruby 2.3.1 and vendor/cache #5

Merged
merged 3 commits into from
Feb 8, 2017

Conversation

Omicron7
Copy link
Contributor

@Omicron7 Omicron7 commented Feb 8, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.569% when pulling a2aa392 on staging into 346ab97 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.569% when pulling 36addea on staging into 346ab97 on master.

@soberstadt
Copy link

We usually don't check in the source files inside of vendor/cache, could you try running bundle package?

@Omicron7
Copy link
Contributor Author

Omicron7 commented Feb 8, 2017

That was from bundle package --all, adds source gems. Figured this would guarantee we had same version when built on other platforms. Things like github:master could differ between builds.

@soberstadt
Copy link

Oh I see now. I would still say that we don't need these in here. With the gemlock file, it should lock down to a specific commit.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.569% when pulling 7ca9603 on staging into 346ab97 on master.

@Omicron7 Omicron7 merged commit d73131d into master Feb 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants