Sort by value spike #218
Closed
Sort by value spike #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scanny
force-pushed
the
sort-by-value-spike
branch
6 times, most recently
from
04e382f
to
c1895aa
Compare
Remove unearned abstraction of separate `._iter_cubes()` method. Inline it in the only caller.
Classic example of YAGNI from a couple years back.
The "Matrix" specifier is redundant, this class is local to the `matrix` module and so can only apply here. I think this naming came from early on when we though that a stripe would just be an unopposed slice-vector, but that of course turned out not to be the case.
Also fix redundant definition for ._anchors which is going away anyway.
OPPOSING_ELEMENT doesn't handle HS yet, need to add some tests for that.
scanny
force-pushed
the
sort-by-value-spike
branch
from
c1895aa
to
ebe0f2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still very much WIP at this point, but it works and it's probably good for folks to be able to take a look at how it's shaping up.