Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort by value spike #218

Closed
wants to merge 54 commits into from
Closed

Sort by value spike #218

wants to merge 54 commits into from

Commits on Nov 9, 2020

  1. fix: docsttrings

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    7c42cdf View commit details
    Browse the repository at this point in the history

  2. fix: suppress targeted divide-by-zero warnings

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    752b701 View commit details
    Browse the repository at this point in the history

  3. test: add unit test for _Slice.scale_means_column

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    923d603 View commit details
    Browse the repository at this point in the history

  4. rfctr: small Dimension implementation improvements

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    917913a View commit details
    Browse the repository at this point in the history

  5. rfctr: condense CubeSet._cubes 

    Remove unearned abstraction of separate `._iter_cubes()` method. Inline
it in the only caller.
    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    47c2c6c View commit details
    Browse the repository at this point in the history

  6. rfctr: remove unused Dimension.sort 

    Classic example of YAGNI from a couple years back.
    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    bf010ef View commit details
    Browse the repository at this point in the history

  7. rfctr: rename _BaseInsertedVector 

    The "Matrix" specifier is redundant, this class is local to the `matrix`
module and so can only apply here. I think this naming came from early
on when we though that a stripe would just be an unopposed slice-vector,
but that of course turned out not to be the case.
    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    41e45ad View commit details
    Browse the repository at this point in the history

  8. xfail: XFAILs for _BaseInsertedVector.insertion_id

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    1471efd View commit details
    Browse the repository at this point in the history

  9. matrix: add _BaseInsertedVector.insertion_id

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    fcdc49a View commit details
    Browse the repository at this point in the history

  10. dim: add _Subtotal.insertion_id

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    7eaefa9 View commit details
    Browse the repository at this point in the history

  11. dim: add _Subtotal.insertion_id fallback 

    Also fix redundant definition for ._anchors which is going away anyway.
    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    f48a7f8 View commit details
    Browse the repository at this point in the history

  12. xfail: add XFAIL for PayloadOrderCollator

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    aa65cb1 View commit details
    Browse the repository at this point in the history

  13. sort: add _BaseAnchoredCollator.display_order

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    4ce62d8 View commit details
    Browse the repository at this point in the history

  14. sort: add _BaseAnchoredCollator._display_order

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    bd95cf5 View commit details
    Browse the repository at this point in the history

  15. sort: add _BaseAnchoredCollator._base_element_orderings

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    60cf5fc View commit details
    Browse the repository at this point in the history

  16. sort: add PayloadOrderCollator._element_order_descriptors

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    1066b13 View commit details
    Browse the repository at this point in the history

  17. sort: add _BaseCollator._element_ids

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    e47d57e View commit details
    Browse the repository at this point in the history

  18. sort: add _BaseCollator._insertion_orderings

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    3e1fbbe View commit details
    Browse the repository at this point in the history

  19. sort: add _BaseCollator._subtotals

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    b39a133 View commit details
    Browse the repository at this point in the history

  20. sort: add _BaseCollator._insertion_position()

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    3813c07 View commit details
    Browse the repository at this point in the history

  21. sort: add _BaseAnchoredCollator._element_positions_by_id

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    5cac167 View commit details
    Browse the repository at this point in the history

  22. xfail: add XFAIL for ExplicitOrderCollator

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    d254dea View commit details
    Browse the repository at this point in the history

  23. sort: add ExplicitOrderCollator._element_order_descriptors

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    f8109ae View commit details
    Browse the repository at this point in the history

  24. sort: add _BaseCollator._order_dict

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    2ca9d6b View commit details
    Browse the repository at this point in the history

  25. xfail: add XFAIL for MarginalCollator

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    8a4d22c View commit details
    Browse the repository at this point in the history

  26. sort: add MarginalCollator.display_order()

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    e41455e View commit details
    Browse the repository at this point in the history

  27. sort: add _BaseSortByValueCollator._display_order

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    ecaa87e View commit details
    Browse the repository at this point in the history

  28. sort: add _BaseSortByValueCollator._top_subtotal_idxs

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    a94436b View commit details
    Browse the repository at this point in the history

  29. sort: add _BaseSortByValueCollator._descending

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    eaf44c2 View commit details
    Browse the repository at this point in the history

  30. sort: add _BaseSortByValueCollator._subtotal_idxs

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    ae5ec6b View commit details
    Browse the repository at this point in the history

  31. sort: add MarginalCollator._subtotal_values

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    9d763df View commit details
    Browse the repository at this point in the history

  32. sort: add MarginalCollator._marginal_propname

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    c696187 View commit details
    Browse the repository at this point in the history

  33. sort: add _BaseSortByValueCollator._top_exclusion_idxs

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    987251d View commit details
    Browse the repository at this point in the history

  34. sort: add _BaseSortByValueCollator._iter_exclusion_idxs()

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    b22381c View commit details
    Browse the repository at this point in the history

  35. sort: add _BaseSortByValueCollator._element_idxs_by_id

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    05101e5 View commit details
    Browse the repository at this point in the history

  36. sort: add _BaseSortByValueCollator._body_idxs

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    1f0b47c View commit details
    Browse the repository at this point in the history

  37. sort: add _BaseSortByValueCollator._bottom_exclusion_idxs

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    11a1f1f View commit details
    Browse the repository at this point in the history

  38. sort: add MarginalCollator._element_values

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    35f82a9 View commit details
    Browse the repository at this point in the history

  39. sort: add _BaseSortByValueCollator._bottom_subtotal_idxs

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    ca502be View commit details
    Browse the repository at this point in the history

  40. xfail: add XFAIL for OpposingElementCollator

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    3751e30 View commit details
    Browse the repository at this point in the history

  41. sort: add OpposingElementCollator.display_order()

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    2be6fd1 View commit details
    Browse the repository at this point in the history

  42. sort: add OpposingElementCollator._subtotal_values

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    8b8b25d View commit details
    Browse the repository at this point in the history

  43. sort: add _BaseSortByValueCollator._measure_propname

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    3f16be1 View commit details
    Browse the repository at this point in the history

  44. sort: add OpposingElementCollator._opposing_vector

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    856585b View commit details
    Browse the repository at this point in the history

  45. sort: add OpposingElementCollator._element_values

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    acbcd28 View commit details
    Browse the repository at this point in the history

  46. xfail: add XFAIL for OpposingSubtotalCollator

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    ce71c55 View commit details
    Browse the repository at this point in the history

  47. sort: add OpposingSubtotalCollator.display_order()

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    726f229 View commit details
    Browse the repository at this point in the history

  48. sort: add OpposingSubtotalCollator._subtotal_values

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    9e1c61b View commit details
    Browse the repository at this point in the history

  49. sort: add OpposingSubtotalCollator._opposing_subtotal

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    393ddd5 View commit details
    Browse the repository at this point in the history

  50. sort: add OpposingSubtotalCollator._element_values

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    aec660e View commit details
    Browse the repository at this point in the history

  51. spike: ExplicitOrderCollator

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    e07b2c7 View commit details
    Browse the repository at this point in the history

  52. xfail: add XFAIL for sort-by-OPPOSING_ELEMENT

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    a5e574b View commit details
    Browse the repository at this point in the history

  53. xfail: XFAIL tests for sort-by-subtotal/marginal

    @scanny
    scanny committed Nov 9, 2020
    Configuration menu
    Copy the full SHA
    410bdc6 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. spike: sort-by-value 

    OPPOSING_ELEMENT doesn't handle HS yet, need to add some tests for that.
    @scanny
    scanny committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    ebe0f2c View commit details
    Browse the repository at this point in the history