Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weighted bases for num arrays 177776376 #279

Merged
merged 13 commits into from
Apr 21, 2021

Conversation

ernestoarbitrio
Copy link
Contributor

@ernestoarbitrio ernestoarbitrio commented Apr 16, 2021

Features:
2 new per cell measures for aggregates:

  • Valid counts unweighted
  • Valid counts weighted
    These 2 measures are now available at the partition level and have to be included in the exports

Refactoring:
Move columns_base from old CubeResultMatrix to the new architecture AKA Assembler

@ernestoarbitrio ernestoarbitrio force-pushed the weighted-bases-for-num-arrays-177776376 branch 2 times, most recently from a8ed399 to a72fb0b Compare April 20, 2021 13:09
@ernestoarbitrio ernestoarbitrio force-pushed the weighted-bases-for-num-arrays-177776376 branch from a72fb0b to 885829a Compare April 20, 2021 13:17
@Crunch-io Crunch-io deleted a comment from coveralls Apr 20, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #279 (2ee123b) into master (4705ad8) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #279    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           20        20            
  Lines         3955      4149   +194     
==========================================
+ Hits          3955      4149   +194     
Impacted Files Coverage Δ
src/cr/cube/cube.py 100.00% <100.00%> (ø)
src/cr/cube/cubepart.py 100.00% <100.00%> (ø)
src/cr/cube/enums.py 100.00% <100.00%> (ø)
src/cr/cube/matrix/assembler.py 100.00% <100.00%> (ø)
src/cr/cube/matrix/cubemeasure.py 100.00% <100.00%> (ø)
src/cr/cube/matrix/measure.py 100.00% <100.00%> (ø)
src/cr/cube/stripe/assembler.py 100.00% <100.00%> (ø)
src/cr/cube/stripe/cubemeasure.py 100.00% <100.00%> (ø)
src/cr/cube/stripe/measure.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4705ad8...2ee123b. Read the comment docs.

@ernestoarbitrio ernestoarbitrio merged commit 5066fa1 into master Apr 21, 2021
@ernestoarbitrio ernestoarbitrio deleted the weighted-bases-for-num-arrays-177776376 branch April 21, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants