Weighted proportions for overlaps 177801573 #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change one overlaps fixture to include weighted counts alongside overlaps, to demonstrate the difference in z scores expectation
* Change how percentages are calculated for overlaps measures * Use weighted counts instead of (unweighted) overlaps selected counts * Prevent regression by changing a fixture and an expectation in a test
slobodan-ilic
force-pushed
the
weighted-proportions-for-overlaps-177801573
branch
from
13f9f80
to
297a726
Compare
ernestoarbitrio
requested changes
Apr 19, 2021
| @@ -512,25 +512,29 @@ def test_pairwise_significance_mr_x_mr(self): | |||
| def test_pairwise_cat_x_mr_gender_x_all_pets_owned(self): | |||
There was a problem hiding this comment.
I would use the suffix _weighted where it's needed in the test name. This way we understand that we are testing the cube with a weight
| @@ -565,6 +566,7 @@ def p_vals(self): | |||
| [ | |||
| [ | |||
| _PairwiseSignificaneBetweenSubvariablesHelper( | |||
| self._cube_measures.weighted_cube_counts.weighted_counts, | |||
There was a problem hiding this comment.
what if weighted_counts is None? This is an optional cube measure and if it doesn't exists its value is None. Do we have a test that exercises this case?
* Add `weighted` to the test name * Remove weighted counts from one fixture, to demonstrate that the overlaps column proportions calculation still works (defaults to weighted counts)
ernestoarbitrio
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per ticket