-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
187-5 fork handler integrated into tezos indexer #903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83e56d1
to
96f73fd
Compare
1a4c00e
to
3faaf58
Compare
681938b
to
ff8d4ee
Compare
e1228fc
to
b28ea77
Compare
vishakh
reviewed
Sep 26, 2020
conseil-lorre/src/main/scala/tech/cryptonomic/conseil/indexer/tezos/TezosIndexer.scala
Show resolved
Hide resolved
conseil-lorre/src/main/scala/tech/cryptonomic/conseil/indexer/tezos/TezosIndexer.scala
Show resolved
Hide resolved
conseil-lorre/src/main/scala/tech/cryptonomic/conseil/indexer/tezos/TezosIndexer.scala
Show resolved
Hide resolved
...-lorre/src/main/scala/tech/cryptonomic/conseil/indexer/tezos/processing/ForksProcessor.scala
Outdated
Show resolved
Hide resolved
...-lorre/src/main/scala/tech/cryptonomic/conseil/indexer/tezos/processing/ForksProcessor.scala
Show resolved
Hide resolved
piotrkosecki
approved these changes
Sep 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
72affdd
to
ae1917b
Compare
* correct all database types for level as bigint * correct all code modeling levels to use the new alias * give an explicit class to BlockReference for better matching * simplify the node operator tests and add explanatory comments * add test case for loading blocks not indexed in db
* add some log about random generation results during tests * fix an incorrect test
* correct all database types for level as bigint * correct all code modeling levels to use the new alias * give an explicit class to BlockReference for better matching * simplify the node operator tests and add explanatory comments * add test case for loading blocks not indexed in db
* correct all database types for level as bigint * correct all code modeling levels to use the new alias * give an explicit class to BlockReference for better matching * simplify the node operator tests and add explanatory comments * add test case for loading blocks not indexed in db
* define a default id for tezos main fork * change the data to be flagged as invalidated on every entity that is related to a block in some form * remove chimney usage for conversions where the compiler got stuck by some possible bug * bugfix for bakers flag on accounts * update existing tests to get all green * complete tests for database operations returning only valid data
* create an component to handle fork searches * define a custom processor that uses a specific detector to handle forks * move components into a more consistent package structure * rename test objects for the test scenarios about forks
* move the max-indexed-level call outside of the node-operator in the main indexer, to re-use the value in the main loop * update tests
dd314ba
to
0eb6b1e
Compare
SonarCloud Quality Gate failed.
|
This was referenced Sep 29, 2020
vishakh
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #42
This PR is mainly focused on integrating the fork handling in the main indexing process.
This required a couple of adaptations w.r.t. the high-level handler component defined so far:
Take note that the fork detection for tezos uses an "optimistic" approach that recursively tries to contact the node for information, but might fail if the node is not responding, thus bringing down the whole lorre process.
We might want to later improve on that with an retry policy internal to the fork component.
This PR additionally contains a few minor but needed unrelated changes regarding configuration of logging layout, corrections to the metadata related to renamed fields, refactoring of packages and some classes for a more consistent organisation of the code, updates to the smoke tests regression suite.
No changes to the db-schema or api surface.
NOTE This is the last of a long-running streak of PRs to define the overall fork handling strategy.
Before merging it we need to merge the previous PRs #896 #898 #899 and rebase on the new
master
branch, after which thedraft
tag could be removed.