Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discord] Flaming arrows cause crash #46

Closed
2 tasks done
Crystal-Spider opened this issue Jun 21, 2024 · 1 comment
Closed
2 tasks done

[Discord] Flaming arrows cause crash #46

Crystal-Spider opened this issue Jun 21, 2024 · 1 comment
Assignees
Labels
bug Unexpected behavior medium priority Needs to be worked on

Comments

@Crystal-Spider
Copy link
Member

I have confirmed no other issue reports this bug

  • I have searched for existing issues

I have confirmed the mod is installed on the proper side

  • I have installed the mod properly

Current behavior

My singleplayer world has recently started crashing every time there's a flaming arrow.

Expected behavior

The game should not crash and the flaming arrow should behave as in Vanilla.

Steps to reproduce

  1. Enchant a bow with normal flame
  2. Shoot an arrow and hit an entity
  3. The game crashes

Minecraft version

1.20.1

Mod loader version

Any

Mod version

1.20.1

Other mods

None

Stacktrace and logs

The game crashed whilst ticking entity
  Error: java.lang.ClassCastException: class net.minecraft.world.item.enchantment.ArrowFireEnchantment cannot be cast to class it.crystalnest.soul_fire_d.api.enchantment.FireTypedFlameEnchantment (net.minecraft.world.item.enchantment.ArrowFireEnchantment is in module minecraft@1.20.1 of loader 'TRANSFORMER' @472d7f34; it.crystalnest.soul_fire_d.api.enchantment.FireTypedFlameEnchantment is in module soul_fire_d@4.0.1 of loader 'TRANSFORMER' @472d7f34)

Additional context

No response

@Crystal-Spider Crystal-Spider added bug Unexpected behavior medium priority Needs to be worked on labels Jun 21, 2024
@Crystal-Spider Crystal-Spider self-assigned this Jun 21, 2024
@Crystal-Spider
Copy link
Member Author

Replicated, affects all supported Minecraft versions.

This is due to forcefully casting all fire components for enchantments to the fire typed version, but Vanilla ones can't be cast to those classes. In older versions this wasn't happening because normal fire had no associated enchantments.

Should be able to fix and release by today.

Crystal-Spider added a commit that referenced this issue Jun 21, 2024
Crystal-Spider added a commit that referenced this issue Jun 21, 2024
Crystal-Spider added a commit that referenced this issue Jun 21, 2024
Crystal-Spider added a commit that referenced this issue Jun 21, 2024
Crystal-Spider added a commit that referenced this issue Jun 21, 2024
Crystal-Spider added a commit that referenced this issue Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behavior medium priority Needs to be worked on
Projects
Development

No branches or pull requests

1 participant