Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix turret errors #149

Merged
merged 30 commits into from
Jun 5, 2023
Merged

Fix turret errors #149

merged 30 commits into from
Jun 5, 2023

Conversation

Koud-Wind
Copy link
Collaborator

🤔 What type of PR is this? (check all applicable)

  • 🍕 Addition
  • ⌨️ Productivity
  • 🐛 Bug Fix
  • 🔥 Optimization
  • ⚙️ Configuration
  • 🌟 Quality Of Life
  • ✨ Enhancement
  • 📝 Documentation

📝 Description

🧐 The Rationale

🎯 Key Objectives

🚦 Testing

⏮️ Backwards Compatibility

📚 Related Issues & Documents

🖼️ Screenshots/Recordings

📖 Added to documentation?

  • 📜 README.md
  • 📓 Javadoc
  • 🍕 Comments
  • 🙅 no documentation needed

😄 [optional] What gif best describes this PR or how it makes you feel?

@Koud-Wind Koud-Wind marked this pull request as ready for review June 3, 2023 17:59
@Koud-Wind
Copy link
Collaborator Author

Please hurry up

@Desoroxxx
Copy link
Collaborator

Please hurry up

Okay I get it it's annoying to wait, but it's better for us to take our time and actually test and verify things than to just merge stuff as fast as possible and worsen the current spaghetti situation.

So will test this when I can to see what is happening.

@Koud-Wind
Copy link
Collaborator Author

Koud-Wind commented Jun 4, 2023

I have tested it, and it is all right. I just deleted if and added switch.

@Koud-Wind
Copy link
Collaborator Author

Added the clear GUI button, perhaps this is #156 Solution, #157 Possible error based on the former

@@ -22,6 +22,7 @@ public CustomPlayerInventoryGuiContainer(EntityPlayer player, InventoryPlayer in
@Override
public void initGui() {
super.initGui();
this.buttonList.clear();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. unnecessary
  2. Please do not touch anything related to the equipment system as it's being reworked in Equipment Overhaul #138

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a statement that was once included, you may have forgotten to add it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator

@Desoroxxx Desoroxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub makes it hard to see but seems fine to me

@Desoroxxx
Copy link
Collaborator

⚠️ Important Notice

For enhanced workflow efficiency, please adhere to the following:

  1. Use branches, not forks, within this repository.
  2. Initiate modifications on a new branch (e.g., "Turret-Fix").
  3. Once your pull request is merged, delete the branch.

Following these steps not only tidies the repository, but also accelerates the review process. Thank you!

@Desoroxxx Desoroxxx merged commit 2c6fddb into Cubed-Development:master Jun 5, 2023
@Koud-Wind
Copy link
Collaborator Author

Please close this issue, #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants