-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Equipment Overhaul #138
Merged
Merged
Equipment Overhaul #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2023
Closed
Merged
Closed
Removed CompatibilityClassGenerator.java
โฆment/Modern-Warfare-Cubed into Equipment-Overhaul
โฆeems not to accept capital letters.
Fixes #143 |
This reverts commit eb32ecb.
Going to merge since the conflicts just keep on going, plus this basically became the master branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ค What type of PR is this? (check all applicable)
๐ Description
This pr aims at improving the equipment system in its globality from making it easier to create equipment, documenting it, adding icons for the users, and adding new features.
๐ง The Rationale
too tired to explain in a good way, will remake most of this at one point
๐ฏ Key Objectives
๐ฆ Testing
Tested on client and server
โฎ๏ธ Backwards Compatibility
This change is backward compatible with older versions so far.
๐ Related Issues & Documents
Needs #137
๐ผ๏ธ Screenshots/Recordings
Coming soon once visual changes are introduced
๐ Added to documentation?
๐ What gif best describes this PR or how it makes you feel?