Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equipment Overhaul #138

Merged
merged 73 commits into from
Jul 19, 2023
Merged

Equipment Overhaul #138

merged 73 commits into from
Jul 19, 2023

Conversation

Desoroxxx
Copy link
Collaborator

@Desoroxxx Desoroxxx commented May 30, 2023

๐Ÿค” What type of PR is this? (check all applicable)

  • ๐Ÿ• Addition
  • โŒจ๏ธ Productivity
  • ๐Ÿ› Bug Fix
  • ๐Ÿ”ฅ Optimization
  • โš™๏ธ Configuration
  • ๐ŸŒŸ Quality Of Life
  • โœจ Enhancement
  • ๐Ÿ“ Documentation

๐Ÿ“ Description

This pr aims at improving the equipment system in its globality from making it easier to create equipment, documenting it, adding icons for the users, and adding new features.

๐Ÿง The Rationale

too tired to explain in a good way, will remake most of this at one point

๐ŸŽฏ Key Objectives

  • Cleaning the equipment system
  • Improving User Experience
  • Making it easier to create equipment
  • Documenting the equipment system

๐Ÿšฆ Testing

Tested on client and server

โฎ๏ธ Backwards Compatibility

This change is backward compatible with older versions so far.

๐Ÿ“š Related Issues & Documents

Needs #137

๐Ÿ–ผ๏ธ Screenshots/Recordings

Coming soon once visual changes are introduced

๐Ÿ“– Added to documentation?

  • ๐Ÿ“œ README.md
  • ๐Ÿ““ Javadoc
  • ๐Ÿ• Comments
  • ๐Ÿ™… no documentation needed

๐Ÿ˜„ What gif best describes this PR or how it makes you feel?

This was referenced Jun 1, 2023
@Desoroxxx
Copy link
Collaborator Author

Fixes #143

@Desoroxxx Desoroxxx linked an issue Jul 17, 2023 that may be closed by this pull request
@Desoroxxx
Copy link
Collaborator Author

Going to merge since the conflicts just keep on going, plus this basically became the master branch

@Desoroxxx Desoroxxx merged commit 4991cb3 into master Jul 19, 2023
@Desoroxxx Desoroxxx deleted the Equipment-Overhaul branch July 19, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some small bugs I encountered during bug testing
4 participants