Added Python 3.3 support #23
Conversation
| @@ -384,6 +385,7 @@ def _aggregate(self, source, aggregators, data, result): | |||
|
|
|||
| else: | |||
| # We found a leaf. | |||
| print(aggregators) | |||
|
Thank you thobbs. I just pushed the fixes. |
| self.graphite.log(prefix + self._sanitize(name), value) | ||
|
|
||
|
|
||
| def _addRule(self, isWhitelist, rule): | ||
| """Add an (isWhitelist, rule) pair to the rule list.""" | ||
| if isinstance(rule, basestring) or hasattr(rule, '__call__'): | ||
| if isinstance(rule, six.string_types[0]) or hasattr(rule, '__call__'): |
There was a problem hiding this comment.
isinstance() accepts a tuple for the second argument, so this could just be isinstance(rule, six.string_types).
|
@pydeveloper94 from my perspective, this should be looking pretty good after the last comments are addressed. Dear project maintainers, how is this looking to you guys? We're in the process of adding Python 3 support to the Cassandra driver and this is a dependency. Let us know if there's anything you'd like done differently. |
|
And now, after grabbing a few other pull requests and setting up Travis-CI testing, I've released a new version to PyPI that incorporates your Python 3 fixes. Thanks! |
|
@PeterScott awesome, thanks very much! I really appreciate it, especially making a new release. |
Hi,
I've added Python 3.3 support to this project. All tests pass in versions 2.6, 2.7, and 3.3. Please look at the 2to3 branch for all changes.