-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Mapping GCP Secret Name -> Configuration Name #2
Comments
Interesting idea. So you have an existing GCP secret manager with existing keys that are used by other projects and would like to reuse those secrets? My plan is to follow as closely as possible with the Azure Key Vault .Net implementation. So for this feature, we would likely implement something similar to |
Essentially. Or, for various reasons, want to share a GCP secret between projects without coupling their dotnet configuration structure
That seems like a good idea to me - looks to be quite extendable. |
* Support custom key mapping * Update README.md * Make default loader methods virtual so they can be overridden * Small refactor for tests * Add tests to verify loader is called from provider Closes #2
With version 2.0.0 there is now You can also inherit from the default implementation of the interface named Let me know if there are any issues and let's look into those :) |
Would you be interested accepting a PR to allow some options to map the GCP secret name to dotnet config name.
Something like:
"my-gcp-secret"
->"My:Dotnet:Value"
This would be helpful in removing the need for the GCP name to match the structure of the project, allow the dotnet app settings to be refactored without affecting the secrets manager, etc.
The text was updated successfully, but these errors were encountered: