Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement configuration loader #3

Merged
merged 5 commits into from
Mar 5, 2022

Conversation

Cultti
Copy link
Owner

@Cultti Cultti commented Mar 4, 2022

Implements configuration loader that allows custom mapping with secert names. Also exposes method that allows us to exclude/include specific secrets from the aplication.

Closes #2

@codecov-commenter
Copy link

Codecov Report

Merging #3 (2bc2f51) into develop (05afb77) will increase coverage by 0.20%.
The diff coverage is 94.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop       #3      +/-   ##
===========================================
+ Coverage    88.40%   88.60%   +0.20%     
===========================================
  Files            5        6       +1     
  Lines           69       79      +10     
===========================================
+ Hits            61       70       +9     
- Misses           8        9       +1     
Impacted Files Coverage Δ
...ager.Provider/SecretManagerConfigurationOptions.cs 66.66% <0.00%> (-33.34%) ⬇️
...rovider/DefaultSecretManagerConfigurationLoader.cs 100.00% <100.00%> (ø)
...ger.Provider/SecretManagerConfigurationProvider.cs 100.00% <100.00%> (ø)
...nager.Provider/SecretManagerConfigurationSource.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05afb77...2bc2f51. Read the comment docs.

@Cultti Cultti changed the title Implement configuration loader #2 Implement configuration loader Mar 5, 2022
@Cultti Cultti changed the title #2 Implement configuration loader Implement configuration loader Mar 5, 2022
@Cultti Cultti merged commit 55dcc4a into develop Mar 5, 2022
@Cultti Cultti deleted the feature/implement-configuration-loader branch March 5, 2022 05:57
Cultti added a commit that referenced this pull request Mar 5, 2022
Added features:
- Implement configuration loader #3
- Upgrade package `Microsoft.Extensions.Configuration` to 3.1.22 (Drops support for .Net core 2.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Mapping GCP Secret Name -> Configuration Name
2 participants