Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Chinese translation and automatic theme color switcher. #19

Merged
merged 5 commits into from
Jun 8, 2024

Conversation

listill
Copy link
Contributor

@listill listill commented Jun 8, 2024

Since I discovered the extension, it has saved me a lot of time securing email addresses.

To make this extension better, I did the following two things.

  1. Added an "Auto" theme pattern to follow the system's preferences.
  2. added Chinese support, I believe this can help more Chinese users to use the extension better.

Finally, thank you for the open source.

@Curetix Curetix changed the base branch from main to development June 8, 2024 10:42
@Curetix Curetix merged commit a2bd5af into Curetix:development Jun 8, 2024
3 checks passed
@Curetix
Copy link
Owner

Curetix commented Jun 8, 2024

Thanks a lot for your contribution, I just made some small adjustments. If you have any other suggestions, feel free to let me know 🙂

@listill
Copy link
Contributor Author

listill commented Jun 8, 2024

As a small suggestion, I've adjusted the LANGUAGE_ENGLISH field in Chinese based on your change, which is only a one character change.

Do I need to start a new Pull Request, or can you check my commit and you can do the change?

LANGUAGE_ENGLISH: "🇬🇧 英文 (English)",
LANGUAGE_ENGLISH: "🇬🇧 英语 (English)",

@Curetix
Copy link
Owner

Curetix commented Jun 8, 2024

As a small suggestion, I've adjusted the LANGUAGE_ENGLISH field in Chinese based on your change, which is only a one character change.

Do I need to start a new Pull Request, or can you check my commit and you can do the change?

LANGUAGE_ENGLISH: "🇬🇧 英文 (English)", LANGUAGE_ENGLISH: "🇬🇧 英语 (English)",

No problem, I updated it.

@listill
Copy link
Contributor Author

listill commented Jun 8, 2024

Great, I don't have any other more suggestions for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants