[bugfix] setting false value to a key in a record + freeing up key names #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prometh07
reviewed
Feb 23, 2017
| @@ -4,8 +4,6 @@ | |||
|
|
|||
| module Deepstream | |||
| class Record | |||
| attr_reader :name, :data, :version | |||
prometh07
reviewed
Feb 23, 2017
| @@ -14,6 +12,10 @@ def initialize(client, name) | |||
| @client.send_message(TOPIC::RECORD, ACTION::CREATEORREAD, @name) | |||
| end | |||
|
|
|||
| def get_name | |||
There was a problem hiding this comment.
You could have used record.data['name'] to get a value when a record's data contained a key 'name'. Right now you can't get the whole data hash at all (whether it should by always a hash, however, is a different issue).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.