Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LED's to display robot state #46

Closed
wants to merge 3 commits into from
Closed

Conversation

SturrockPeter
Copy link

@SturrockPeter SturrockPeter commented Jun 16, 2024

Finished LED integration within arm states

Resolves #40

SturrockPeter and others added 2 commits June 16, 2024 12:28
Resolves #15
Closes #39

Co-authored-by: Jade <spacey-sooty@proton.me>
Co-authored-by: koz <kido3508@gmail.com>
@SturrockPeter SturrockPeter requested a review from a team as a code owner June 16, 2024 06:49
@spacey-sooty spacey-sooty changed the title Peter/ledintegration Add LED's to display robot state Jun 16, 2024
@spacey-sooty
Copy link
Member

/format

Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should display info about intaking and robot position as well.
Needs coordination with driveteam and @totallysomeoneyoudontknow
cc @Hazzer890 I'm sure you have an opinion on what the LEDs should do

Comment on lines 135 to 150
lEDPwm.setSpeed(0.67);
break;

case kIntake:
case kSpeaker:
position = 3.7;
lEDPwm.setSpeed(0.73);
break;

case kSpeaker:
case kIntake:
position = 3.7;
lEDPwm.setSpeed(0.57);
break;

case kStowed:
position = 3.7;
lEDPwm.setSpeed(0.99);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have comments to say what that actually displays, its not obvious from the code

@@ -42,6 +43,8 @@ public enum Setpoint {
private DoubleLogEntry log_ff_output = new DoubleLogEntry(m_log, "/arm/ff/output");
private StringLogEntry log_setpoint = new StringLogEntry(m_log, "/arm/setpoint");

PWM lEDPwm = new PWM(0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this port needs to be determined still no?

Suggested change
PWM lEDPwm = new PWM(0);
private PWM m_led = new PWM(0);

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this port needs to be determined still no?

maybe, was going off memory, could also be port 1

@SturrockPeter
Copy link
Author

IMO we should display info about intaking and robot position as well. Needs coordination with driveteam and @totallysomeoneyoudontknow cc @Hazzer890 I'm sure you have an opinion on what the LEDs should do

currently working off LED patterns decided with Layla during season.

Comment on lines 135 to 150
lEDPwm.setSpeed(0.67); // gold //
break;

case kIntake:
case kSpeaker:
position = 3.7;
lEDPwm.setSpeed(0.73); // lime //
break;

case kSpeaker:
case kIntake:
position = 3.7;
lEDPwm.setSpeed(0.57); // hot pink //
break;

case kStowed:
position = 3.7;
lEDPwm.setSpeed(0.99); // blank //
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing slashes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status LEDs
2 participants