Fix a crash within LTCG SetBorderColor, fix off-by-one error in mip-map level test #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…polines don't work right for LTCG titles
LukeUsher
commented
Oct 30, 2018
| @@ -5734,7 +5734,9 @@ VOID XTL::EMUPATCH(D3DDevice_SetTextureState_BorderColor_0) | |||
| } | |||
|
|
|||
|
|
|||
| return EMUPATCH(D3DDevice_SetTextureState_BorderColor)(Stage, Value); | |||
| HRESULT hRet; | |||
| hRet = g_pD3DDevice->SetSamplerState(Stage, D3DSAMP_BORDERCOLOR, Value); | |||
There was a problem hiding this comment.
This change was made because trampolines do not work, and cannot be made to work for non-standard LTCG calling conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.